Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds hardware model string to NodeInfo card ui if available #1111

Merged
merged 3 commits into from
Jul 2, 2024

Conversation

jamesarich
Copy link
Contributor

Adds hardware model string to NodeInfo cards if available

image

@CLAassistant
Copy link

CLAassistant commented Jun 28, 2024

CLA assistant check
All committers have signed the CLA.

@garthvh garthvh requested a review from andrekir June 28, 2024 16:02
@rcarteraz
Copy link
Contributor

Adds hardware model string to NodeInfo cards if available

This thing is starting to get pretty busy! I think we really need to consider an updated UI approach to included a dedicated node details page where some of this information can be shown in that view, rather than the little preview card.

@jamesarich
Copy link
Contributor Author

rather than the little preview card

I could see a case for an expandable card as well, with action buttons.

@rcarteraz
Copy link
Contributor

rather than the little preview card

I could see a case for an expandable card as well, with action buttons.

That sounds reasonable in absence of a node details view.

@jamesarich
Copy link
Contributor Author

Expandable cards would need to have more consideration and discussion beyond the original intent of this PR which is to expose the node's hardware model (which fwict is not visible anywhere else). Is there any roadmap or ux guidelines that we could reference here for future UI improvements to expose any other node info not currently visible to the user?

@andrekir andrekir merged commit a59aaf5 into meshtastic:master Jul 2, 2024
4 checks passed
@jamesarich jamesarich deleted the nodeinfo-hwmodel branch July 14, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants