[chore] Support for PersistentVolumes and PersistentVolumeClaims #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eclaims Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
|
Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack. |
leecalcote
reviewed
Apr 14, 2022
| PublishTo: "meshery.meshsync.core", | ||
| }, | ||
| { | ||
| Name: "persistentvolumeclaims.v1.", |
There was a problem hiding this comment.
What negative ramifications are involved in removing the “v1“? Any? If not, please do.
| @@ -29,6 +29,14 @@ var ( | |||
| Name: "secrets.v1.", | |||
| PublishTo: "meshery.meshsync.core", | |||
| }, | |||
| { | |||
| Name: "persistentvolumes.v1.", | |||
| PublishTo: "meshery.meshsync.core", | |||
There was a problem hiding this comment.
move to meshery.meshsync.k8s?
|
Thanks for your contribution to the Layer5 community! 🎉
|
This was referenced Aug 17, 2023
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pranav Singh pranavsingh02@hotmail.com
Description
This PR fixes #
Notes for Reviewers
Please check the supporting PR on meshery-extension repo as well
Signed commits