New Flowchart Shapes (with new syntax) #5825
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* upstream/develop: [autofix.ci] apply automated fixes test: fix gantt.spec.js type error test: await on `expect().resolves/rejects` build(types): disable preserveSymlinks in tsconfig
|
Reopened to get pkg.pr.new to run. |
* develop: chore: Run release-preview on more PR events
This reverts commit d37d77c.
commit: |
… into knsv/new-shapes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Summary
This pull request introduces several new flowchart shapes along with their test, updates to the configuration files, and improvements to the documentation.
**The most important changes include a guide for other contributors on how to add a new custom shape for flowcharts.
New Tests and Configurations:
cypress/integration/rendering/flowchart-v2.spec.js: Added a test to render self-loops in flowcharts.cypress/integration/rendering/newShapes.spec.ts: Introduced comprehensive tests for new shapes, including various looks, directions, labels, and styles.cypress/integration/rendering/oldShapes.spec.ts: Added tests for existing shapes with different looks and directions.Configuration Updates:
.cspell/cspell.config.yaml: Added new words to the dictionary definitions.Documentation Enhancements:
docs/adding_new_shape/Readme.md: Added detailed documentation on the available utilities for creating new shapes, instructions for adding new shapes, and information on running Cypress tests.These changes collectively enhance the robustness of the flowchart rendering capabilities and provide clear guidelines for extending the shape library.
Brief description about the content of your PR.
Resolves #
📏 Design Decisions
Describe the way your implementation works or what design decisions you made if applicable.
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSIONis used for all new features.pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.