Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codecov #4504

Merged
merged 5 commits into from
Jun 17, 2023
Merged

Add codecov #4504

merged 5 commits into from
Jun 17, 2023

Conversation

sidharthv96
Copy link
Member

📑 Summary

Brief description about the content of your PR.

Resolves #

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added unit/e2e tests (if appropriate)
  • 📓 have added documentation (if appropriate)
  • 🔖 targeted develop branch

@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2023

Codecov Report

❗ No coverage uploaded for pull request base (develop@702c3ea). Click here to learn what that means.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #4504   +/-   ##
==========================================
  Coverage           ?   81.14%           
==========================================
  Files              ?      136           
  Lines              ?    10446           
  Branches           ?      492           
==========================================
  Hits               ?     8476           
  Misses             ?     1815           
  Partials           ?      155           
Flag Coverage Δ
e2e 80.99% <0.00%> (?)
unit 28.28% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@sidharthv96 sidharthv96 merged commit 548874e into develop Jun 17, 2023
22 checks passed
@Yokozuna59
Copy link
Member

@sidharthv96 should we relay on the old code coverage badge? I think it might be better to add codecov coverage badge on root README.md

@sidharthv96
Copy link
Member Author

sidharthv96 commented Jun 17, 2023

Yes, the old one can be removed.
Can you raise the PR?

@Yokozuna59
Copy link
Member

Yokozuna59 commented Jun 17, 2023

Sure! but you have to go to settings and enable it so it can be displayed. It's publicly exposed yet:

codecov

it was wrong url.
codecov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants