Dongc/zenuml #4411
Merged
Dongc/zenuml #4411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
aloisklink
approved these changes
May 17, 2023
There was a problem hiding this comment.
Looks good to me! Thanks for making those changes.
Since this PR is going to be merged into the sidv/zenuml branch (PR #4334), I'm going to merge this now since it's going to go through another review in that PR, before being merged to develop!
|
Thank you so much for your reviews. I've learned a lot from it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Summary
A follow-up of #4405 which addresses a couple of extra comments from @aloisklink
📋 Tasks
ZenUMLtype errorMake sure you