Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mindmap with a node over a certain length causes an infinite loop #4408

Closed
jeffreykwan opened this issue May 16, 2023 · 2 comments · Fixed by #4416
Closed

Mindmap with a node over a certain length causes an infinite loop #4408

jeffreykwan opened this issue May 16, 2023 · 2 comments · Fixed by #4416
Labels
Contributor needed Good first issue! Graph: Mindmap Status: Approved Is ready to be worked on Type: Bug / Error Something isn't working or is incorrect

Comments

@jeffreykwan
Copy link

Description

When I create a mindmap with a node that's over a certain length it causes the browser to crash. I believe it's a infinite loop. I was able to reproduce this using a node with abcdefghijklmnopqrstuvwxy or in japanese プロダクトマネジメントプロ

Chrome profile (had to zip to upload to Github)
mermaid infinite loop Profile-20230516T134824.json.zip

Steps to reproduce

Live Preview link

  1. Create a mindmap
  2. Add a node named abcdefghijklmnopqrstuvwxy
  3. Browser crashes

Screenshots

image

Code Sample

https://mermaid.live/edit#pako:eNoljDEOgkAQRa9CpoKEE1DrCWin2bAjbmQXss4WhpAYprGxpjPxAMbCxvvMRUTtXt77-SM0vSWowLtgvRkwIMe-5zzfhtYFopjVB9d1x6L4JmSVReWhctb5qXJRualcdX6r3FVeP7NACZ6iN86uxyOGLEPgPXlCqFa0tDOpYwQM0zo1ifv6FBqoOCYqIQ3WMG2caaPxfzl9AK2eRcE

or

https://mermaid.live/edit#pako:eNoljEEOgzAMBL8S-QQSL-DcvoCrLy5xISV2aHBoK8Tfm6q31c7OHjAmz9CDBPVCKypaTsma5qpTUObshiXEuLXtD6HRbfR8n-bwWKJoWp95s7K_3tCBcBYKvp4dqM4h2MzCCH2N1aESDQH1rFMqloaPjtBbLtxBWT0ZXwJNmeRfnl8c3jfW

mindmap
	root((Engineer Skills))
		プロダクトマネジメントプロ

mindmap
	root((Engineer Skills))
		abcdefghijklmnopqrstuvwxy

Setup

  • Mermaid version: Latest (the version mermaid.live uses)
  • Browser and Version: Chrome Version 113.0.5672.92 (Official Build) (arm64)

Additional Context

No response
@jeffreykwan jeffreykwan added Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect labels May 16, 2023
@jeffreykwan jeffreykwan changed the title Infinite loop Mindmap with a node over a certain length causes an infinite loop May 16, 2023
@sidharthv96 sidharthv96 added Contributor needed Status: Approved Is ready to be worked on Good first issue! Graph: Mindmap and removed Status: Triage Needs to be verified, categorized, etc labels May 17, 2023
@AmalChandru
Copy link

@sidharthv96 Can I try this?

@sidharthv96
Copy link
Member

Ofcourse. All issues without any PRs are open for everyone to try. :)

MikeJeffers added a commit to MikeJeffers/mermaid that referenced this issue May 20, 2023
@MikeJeffers
Fixes mermaid-js#4408: solve infinite loop on words that exceed width…
f535640 
… constraint with word break
@MikeJeffers MikeJeffers mentioned this issue May 20, 2023
Merged
4 tasks
@sidharthv96 sidharthv96 mentioned this issue Jun 7, 2023
Closed
sidharthv96 added a commit that referenced this issue Jun 8, 2023
@sidharthv96
Merge pull request #4416 from MikeJeffers/bug/4408
f464212 
Fix #4408: Handle wrapping long words
@aloisklink aloisklink mentioned this issue Jul 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Contributor needed Good first issue! Graph: Mindmap Status: Approved Is ready to be worked on Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #4408: Handle wrapping long words MikeJeffers/mermaid
3 participants
@jeffreykwan @sidharthv96 @AmalChandru