Skip to content

Commit

Permalink
Merge pull request #4194 from mermaid-js/chore/skip-setup-node-cachin…
Browse files Browse the repository at this point in the history
…g-in-e2e-ci

CI(e2e): Skip caching in `actions/setup-node`, as `cypress-io/github-action` already caches for us
  • Loading branch information
sidharthv96 committed Mar 7, 2023
2 parents 6b5221e + f0a7369 commit 7bea44e
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions .github/workflows/e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,7 @@ jobs:

- name: Setup Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
# Need to skip setup if Cypress run is skipped, otherwise an error
# is thrown since the pnpm cache step fails
if: ${{ ( env.CYPRESS_RECORD_KEY != '' ) || ( matrix.containers == 1 ) }}
with:
cache: pnpm
node-version: ${{ matrix.node-version }}

# Install NPM dependencies, cache them correctly
Expand Down

0 comments on commit 7bea44e

Please sign in to comment.