-
-
Notifications
You must be signed in to change notification settings - Fork 616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replacing "graph" with "flowchart" #654
Conversation
Since the documentation mentions "flowchart" in the example pages, it makes more sense to also show a flowchart as the first example loaded in the editor. It looks to me like "graph" was deprecated? Not 100% sure.
✅ Deploy Preview for mermaidjs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Thanks @victorp13 !
|
The snapshot tests seem to be failing due to the changes in mermaid-live-editor/cypress/snapshots.js Lines 4 to 25 in 4528d8c
And in
Could you update those too? |
Okay, so this is a valid bug when loading images Works
Does not work
So there is compatibility difference with This needs to be addressed in the mermaid library and is not directly linked to this PR. @knsv @ashishjain0512 is this an intentional omission in flowchart? |
This pr is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 14 days |
* origin/develop: (509 commits) chore(deps): update all non-major dependencies chore(deps): update dependency eslint to v8.33.0 chore(deps): update all non-major dependencies chore(deps): update all non-major dependencies chore(deps): update all non-major dependencies chore(deps): update all non-major dependencies chore(deps): update dependency eslint to v8.30.0 Fix links chore(deps): update all non-major dependencies SvelteKit 1.0! Update sveltekit Skip updatebrowserslit on renovate v9.3.0 mermaid 9.3.0-rc.7 Fix vite.config.js typing mermaid 9.3.0-rc.6 rc.5 fix: Adjust image size Update to rc.4 Update to rc.3 ...
…ditor into pr/victorp13/654 * 'patch-1' of https://github.com/victorp13/mermaid-live-editor: Update Browserslist
📑 Summary
Since the documentation mentions "flowchart" in the example pages, it makes more sense to also show a flowchart as the first example loaded in the editor. It looks to me like "graph" was deprecated? Not 100% sure.
Resolves #653
📏 Design Decisions
Describe the way your implementation works or what design decisions you made if applicable:
📋 Tasks
Make sure you
develop
branch