[Added] Added a Logging Middleware that does not truncate mesage payload. #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-ruiz
approved these changes
Apr 8, 2022
csaroff
pushed a commit
to csaroff/rele
that referenced
this pull request
Apr 19, 2023
…oad. (mercadona#218) * Add verbose logging middleware * Add VerboseLoggingMiddleware to contrib/__init__.py * Fix linting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What?
Added a
VerboseLoggingMiddlewarethat mimics the output format of the currentLoggingMiddlewarebut does not truncate the message payload on the post_process and pre_publish failure hooks.🤔 Why?
The current
LoggingMiddlewarerelies on the__repr__()method of the google pubsub message, which truncates the message payload. This, in turn, means that any message payload log will have that payload truncated.The
VerboseLoggingMiddlewareimplementation proposed in this PR adheres to the exact same behavior and formatting of the existingLoggingMiddleware, but enabling non-truncated message payload logs.