Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite Basic's docs to cover the CLI #162

Merged
merged 1 commit into from
Jun 1, 2020
Merged

Rewrite Basic's docs to cover the CLI #162

merged 1 commit into from
Jun 1, 2020

Conversation

andrewgy8
Copy link
Contributor

@andrewgy8 andrewgy8 commented May 29, 2020

🎩 What?

  • Documentation of the cli on the basics section
  • Also some linting on unused imports
  • Change the debug log in the autodiscover to info

🤔 Why?

Its no longer necessary to write your own worker.

🔗 Related issue

#160

Screen Shot 2020-05-29 at 6 01 16 PM

config.ack_deadline,
)
worker.run_forever()
.. note:: Autodiscovery of subscribers with ``rele-cli`` follows a strict directory structure.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@@ -2,7 +2,6 @@
import logging
import time

import rele
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come linting did not catch this before?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😞 we dont have isort on this project. Ill submit another PR for this.

@andrewgy8 andrewgy8 changed the title Rewrite Basics docs to cover the CLI Rewrite Basic's docs to cover the CLI Jun 1, 2020
@andrewgy8 andrewgy8 merged commit af8359b into master Jun 1, 2020
@andrewgy8 andrewgy8 deleted the docs-on-cli branch June 1, 2020 12:59
csaroff pushed a commit to csaroff/rele that referenced this pull request Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants