Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test i686 and s390x on CI #139

Merged
merged 1 commit into from
Aug 10, 2024
Merged

test i686 and s390x on CI #139

merged 1 commit into from
Aug 10, 2024

Conversation

folkertdev
Copy link
Collaborator

@folkertdev folkertdev commented Aug 10, 2024

fixes #134

by just ignoring those tests. The error is not a real error in that we produce something different form zlib(-ng) on those platforms, but our output is still valid.

On CI, I can't get the cross-compilation of zlib-ng to work, but I did run this locally (where cross-compilation does work?!) . We now test the zlib-rs crate on i686 and s390x, so real logic errors should be caught by that. I'll give cross-compiling zlib-ng another go at a later point.

@folkertdev folkertdev force-pushed the qemu-ci branch 2 times, most recently from b532671 to 642f3ef Compare August 10, 2024 13:05
Copy link

codecov bot commented Aug 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.25%. Comparing base (0cfb39d) to head (8cfb75f).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #139      +/-   ##
==========================================
+ Coverage   91.23%   91.25%   +0.02%     
==========================================
  Files          41       41              
  Lines       13181    13200      +19     
==========================================
+ Hits        12026    12046      +20     
+ Misses       1155     1154       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@folkertdev folkertdev force-pushed the qemu-ci branch 17 times, most recently from 57ce15b to dcb85d5 Compare August 10, 2024 14:35
@folkertdev folkertdev changed the title WIP: add QEMU CI support test i686 and s390x on CI Aug 10, 2024
@folkertdev folkertdev merged commit a850c86 into main Aug 10, 2024
16 checks passed
@folkertdev folkertdev deleted the qemu-ci branch August 10, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test failures on i686-unknown-linux-gnu
1 participant