Add support for AWS credentials #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks so much @koenrh! I'll review this tomorrow. The addition of minitest is great 😄 |
|
Doesn't find a lot (which is good I guess), but works great! Thanks again. |
|
@melvinsh You're welcome! I guess this particular plugin makes more sense for private repositories. I use this tool mostly for internal auditing, i.e. scanning private repositories on GitHub and hosted GitHub installations (I should probably send in this patch). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for extracting AWS credentials from
configandcredentialsfiles, the two configuration files commonly used by AWS CLI and SDKs.I took the liberty to add a very basic unit test (using minitest) for this plugin. Feel free to ignore it and only merge the plugin file.