Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autoplay stops after user interaction #590

Merged
merged 1 commit into from
Oct 11, 2019

Conversation

HelloCore
Copy link
Contributor

Platforms affected

Both iOS and Android

What does this PR do?

Fix autoplay stops after user interaction #452.

What testing has been done on this change?

Scroll manually if autoplay = true, or after calling startAutoplay, and it should continue autoplay after scrolling.

Tested features checklist

@bd-arc
Copy link
Contributor

bd-arc commented Oct 5, 2019

Hi @HelloCore,

Are you still experiencing the issue? Because this commit was supposed to fix it...

@HelloCore
Copy link
Contributor Author

HelloCore commented Oct 5, 2019

Hi @HelloCore,

Are you still experiencing the issue? Because this commit was supposed to fix it...

Yes, I still got that.
One thing I know is we didn't extract autoplay from this.props (inside _onTouchEnd), so it seems to always be undefined. 406c8f0#diff-580e5b51e04540b35aed2cd2486a1a24R850
Another thing is if we called startAutoplay, it's going to call stopAutoplay when touching.

In my case, I had Carousel on the first screen, and I wanted it to autoplay only when it was focused, so I set autoplay to false, and called startAutoplay directly instead.

@bd-arc bd-arc merged commit e7b563d into meliorence:master Oct 11, 2019
@bd-arc
Copy link
Contributor

bd-arc commented Oct 11, 2019

Thanks @HelloCore!

I've merged your PR and made it available in version 3.8.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants