[translation] Greek #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adlk
reviewed
Oct 24, 2017
| @@ -1,6 +1,7 @@ | |||
| module.exports = { | |||
| 'en-US': 'English', | |||
| 'pt-BR': 'Portuguese (Brazil)', | |||
| 'el-GR': 'Ελληνικά (Greece)', | |||
There was a problem hiding this comment.
Wouldn't be "Greek" more appropriate?
If you are going to change anything, I'm more than happy to merge another PR.
There was a problem hiding this comment.
it depends ... i have seen both implementations.
for example Windows use " Greek " as lang selection but Android/iOS use "Ελληνικά".
because it is a messenger app (Program ) it think is more appropriate .
P.S. if you know Greek it will not mater :-P
There was a problem hiding this comment.
That's true. Just thinking of consistency reasons but I guess German (Austrian) or German (Austria) would both be ok as long as we keep one pattern.
adlk
approved these changes
Oct 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added Greek translation
Motivation and Context
https://github.com/meetfranz/franz/issues/39