Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace final material button with ButtonMain cds component [CV2-3353] #2141

Merged
merged 8 commits into from
Oct 3, 2024

Conversation

brianfleming
Copy link
Contributor

@brianfleming brianfleming commented Oct 1, 2024

Description

Noticed while reviewing tickets we only had one instance of mat button left. This PR completes the process. Since internally we are the primary users of this button I didn't worry too much about retaining the styles perfectly. See the screenshots below.

References: CV2-3353

Type of change

  • Performance improvement and/or refactoring (non-breaking change that keeps existing functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Security mitigation or enhancement
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Automated test (add or update automated tests)

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can verify the changes. Please describe whether or not you implemented automated tests.

Things to pay attention to during code review

BEFORE

Screenshot 2024-10-01 at 2 50 17 PM

AFTER

Screenshot 2024-10-01 at 2 49 52 PM

Checklist

  • I have performed a self-review of my own code
  • I've made sure my branch is runnable and given good testing steps in the PR description
  • I considered secure coding practices when writing this code. Any security concerns are noted above.
  • I have commented my code in hard-to-understand areas, if any
  • I have made needed changes to the README
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • If I implemented any new components, they are self-contained, their propTypes are declared and they use React Hooks and, if data-fetching is required, they use Relay Modern with fragment containers
  • If my components involve user interaction - specifically button, text fields, or other inputs - I have added a BEM-like class name to the element that is interacted with
  • To the best of my knowledge, any new styles are applied according to the design system
  • If I added a new external dependency, I included a rationale for doing so and an estimate of the change in bundle size (e.g., checked in https://bundlephobia.com/)
  • If I touched a file that included an eslint-disable-file header, I updated the code such that the disabler can be removed

@brianfleming brianfleming marked this pull request as ready for review October 1, 2024 19:02
@brianfleming
Copy link
Contributor Author

FYI reviewers: Marking this as ready for review, but I don't want to merge it until after the next release tagging

@brianfleming
Copy link
Contributor Author

Thanks @amoedoamorim I am going to merge this after the release.
FYI, i just added one of those small transifex typos reported to this PR to make things easier

@brianfleming brianfleming merged commit 5392223 into develop Oct 3, 2024
4 checks passed
@brianfleming brianfleming deleted the brianfleming/dev/last-button-CV2-3353 branch October 3, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants