run tests on GitHub actions #805
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dmou
commented
Jun 12, 2021
dmou
commented
- runs unit and functional tests in parallel in github actions
- removes travis
caiosba
requested changes
Jun 12, 2021
There was a problem hiding this comment.
Wooo now I can see the tests output! Looks like all are passing!
Just two things:
- Looks like the Slack notification didn't work: https://github.com/meedan/check-api/pull/805/checks?check_run_id=2807491900#step:2:5
- Looks like Code Climate didn't receive the coverage report: https://codeclimate.com/repos/58bdc058359261025a0020fa/settings/test_reporter
dmou
force-pushed
the
dmou/run-tests-github-actions
branch
from
abd653d
to
d18b38b
Compare
and try not rebuilding docker-compose up
and sudo install aws?
dmou
force-pushed
the
dmou/run-tests-github-actions
branch
from
f43891e
to
9dfa7f0
Compare
|
@dmou I know it's been awhile, but do you have a sense for what this PR would need to get merged? remaining to-dos etc? we discussed in retro today how just having test runs in github actions would speed things up since things are getting stuck waiting with the 5 travis runners, so I'm curious about what's left here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.