-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(modules-sdk): Parse filters based on loaded modules graph #9158
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Skipped Deployments
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! 🔥
Lots of stuff going on – think the easiest way to review it is to put it to use. With that in mind, I think we should merge it and get people to start playing around with it.
Important
Mikro orm has a bug when applying
Filters
to relations, it is not correctly propagated (see issue) and the pr that fixes this problem is part of v6 here. So for now it is a known limitation that we currently have. This issue has been discovered as part of that pr but is in fact already existingWhat
Parse query filters and assign them correctly.
Along side having the filters of the Query API typed, it is now possible to filter cross modules (graphql like results) using this kind of typed filters