Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(link-modules): table name #9151

Merged
merged 10 commits into from
Sep 16, 2024
Merged

fix(link-modules): table name #9151

merged 10 commits into from
Sep 16, 2024

Conversation

carlos-r-l-rodrigues
Copy link
Contributor

@carlos-r-l-rodrigues carlos-r-l-rodrigues commented Sep 16, 2024 •
edited
Loading

FIXES: FRMW-2706

@carlos-r-l-rodrigues carlos-r-l-rodrigues requested a review from a team as a code owner September 16, 2024 16:14
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 16, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 03d0e39

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Sep 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview 💬 Add feedback Sep 16, 2024 6:55pm
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 16, 2024 6:55pm
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Sep 16, 2024 6:55pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Sep 16, 2024 6:55pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Sep 16, 2024 6:55pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Sep 16, 2024 6:55pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Sep 16, 2024 6:55pm

olivermrbl
olivermrbl approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's get this in

@kodiakhq kodiakhq bot merged commit d6ff526 into develop Sep 16, 2024
23 checks passed
@kodiakhq kodiakhq bot deleted the fix/link-table-name branch September 16, 2024 19:08
@thetutlage thetutlage mentioned this pull request Sep 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl approved these changes

@riqwan riqwan Awaiting requested review from riqwan riqwan is a code owner automatically assigned from medusajs/engineering

@christiananese christiananese Awaiting requested review from christiananese christiananese is a code owner automatically assigned from medusajs/engineering

@adrien2p adrien2p Awaiting requested review from adrien2p adrien2p is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
automerge team: medusa type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carlos-r-l-rodrigues @olivermrbl