Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dashboard,types): added inbound shipping placeholder + shipping summary details #9150

Merged
merged 6 commits into from
Sep 16, 2024
Merged

feat(dashboard,types): added inbound shipping placeholder + shipping summary details #9150

merged 6 commits into from
Sep 16, 2024

Conversation

riqwan
Copy link
Contributor

@riqwan riqwan commented Sep 16, 2024

what:

  • shipping summary
Screenshot 2024-09-16 at 18 05 37
  • No Shipping options placeholder
Screenshot 2024-09-16 at 18 06 11

@vercel Vercel
Copy link

vercel bot commented Sep 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 16, 2024 8:37pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Sep 16, 2024 8:37pm
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Sep 16, 2024 8:37pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Sep 16, 2024 8:37pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Sep 16, 2024 8:37pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Sep 16, 2024 8:37pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Sep 16, 2024 8:37pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 16, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 855b3b9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@riqwan riqwan marked this pull request as ready for review September 16, 2024 16:07
@riqwan riqwan requested a review from a team as a code owner September 16, 2024 16:07
olivermrbl
olivermrbl approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💪

fPolic
fPolic reviewed Sep 16, 2024
View reviewed changes
Copy link
Contributor

@fPolic fPolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice!

...rd/src/routes/orders/order-detail/components/order-summary-section/shipping-info-popover.tsx Outdated
rmaId = shippingDetail.exchange_id
}

if (typeof shippingDetail !== "object" || !rmaId) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q: why do we check shippingDetail here and on L:12, it should be an object at this point otherwise some of the lines above would throw

...rd/src/routes/orders/order-detail/components/order-summary-section/shipping-info-popover.tsx
<Tooltip
content={
<Badge size="2xsmall" rounded="full">
{rmaType}: #{rmaId.slice(-7)}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: we should translate rmaType

@kodiakhq kodiakhq bot merged commit aa0928d into develop Sep 16, 2024
23 checks passed
@kodiakhq kodiakhq bot deleted the feat/inbound-shipping branch September 16, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fPolic fPolic fPolic left review comments

@olivermrbl olivermrbl olivermrbl approved these changes

@sradevski sradevski Awaiting requested review from sradevski sradevski is a code owner automatically assigned from medusajs/engineering

@kasperkristensen kasperkristensen Awaiting requested review from kasperkristensen kasperkristensen is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
automerge team: medusa type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@riqwan @fPolic @olivermrbl