Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tracing to workflow steps #9140

Merged
merged 21 commits into from
Sep 17, 2024
Merged

Conversation

thetutlage
Copy link
Contributor

@thetutlage thetutlage commented Sep 16, 2024

Fixes: CC-444

Here's the full trace for creating a new product.

CleanShot 2024-09-16 at 12 25 55@2x

Copy link

vercel bot commented Sep 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview 💬 Add feedback Sep 17, 2024 5:45am
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 17, 2024 5:45am
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Sep 17, 2024 5:45am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Sep 17, 2024 5:45am
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Sep 17, 2024 5:45am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Sep 17, 2024 5:45am
resources-docs ⬜️ Ignored (Inspect) Visit Preview Sep 17, 2024 5:45am

Copy link

changeset-bot bot commented Sep 16, 2024

⚠️ No Changeset found

Latest commit: ef47bba

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@sradevski sradevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

packages/medusa/src/loaders/index.ts Show resolved Hide resolved
packages/medusa/src/instrumentation/index.ts Outdated Show resolved Hide resolved
Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can add some ts doc on the traces functions wdyt?

packages/medusa/src/loaders/index.ts Show resolved Hide resolved
@sradevski
Copy link
Member

/snapshot-this

@olivermrbl olivermrbl changed the title feature: add tracing to workflow steps feat: add tracing to workflow steps Sep 16, 2024
Copy link
Contributor

🚀 A snapshot release has been made for this PR

Test the snapshots by updating your package.json with the newly published versions:

yarn add @medusajs/admin-bundler@0.0.2-snapshot-20240916110643
yarn add @medusajs/admin-sdk@0.0.2-snapshot-20240916110643
yarn add @medusajs/admin-shared@0.0.2-snapshot-20240916110643
yarn add @medusajs/admin-vite-plugin@0.0.2-snapshot-20240916110643
yarn add @medusajs/dashboard@0.0.2-snapshot-20240916110643
yarn add create-medusa-app@1.2.9-snapshot-20240916110643
yarn add @medusajs/medusa-cli@1.3.23-snapshot-20240916110643
yarn add medusa-dev-cli@0.0.33-snapshot-20240916110643
yarn add @medusajs/medusa-oas-cli@1.0.0-snapshot-20240916110643
yarn add @medusajs/core-flows@0.0.10-snapshot-20240916110643
yarn add @medusajs/js-sdk@0.0.2-snapshot-20240916110643
yarn add medusa-test-utils@1.1.45-snapshot-20240916110643
yarn add @medusajs/modules-sdk@1.13.0-snapshot-20240916110643
yarn add @medusajs/orchestration@0.5.8-snapshot-20240916110643
yarn add @medusajs/types@1.12.0-snapshot-20240916110643
yarn add @medusajs/utils@1.12.0-snapshot-20240916110643
yarn add @medusajs/workflows-sdk@0.1.7-snapshot-20240916110643
yarn add @medusajs/icons@1.2.2-snapshot-20240916110643
yarn add @medusajs/ui@3.0.1-snapshot-20240916110643
yarn add @medusajs/ui-preset@1.1.4-snapshot-20240916110643
yarn add @medusajs/framework@0.0.2-snapshot-20240916110643
yarn add @medusajs/medusa@1.20.6-snapshot-20240916110643
yarn add medusa-telemetry@0.0.18-snapshot-20240916110643
yarn add @medusajs/api-key@0.1.3-snapshot-20240916110643
yarn add @medusajs/auth@0.0.4-snapshot-20240916110643
yarn add @medusajs/cache-inmemory@1.8.11-snapshot-20240916110643
yarn add @medusajs/cache-redis@1.9.2-snapshot-20240916110643
yarn add @medusajs/cart@0.0.4-snapshot-20240916110643
yarn add @medusajs/currency@0.1.3-snapshot-20240916110643
yarn add @medusajs/customer@0.0.4-snapshot-20240916110643
yarn add @medusajs/event-bus-local@1.9.9-snapshot-20240916110643
yarn add @medusajs/event-bus-redis@1.8.14-snapshot-20240916110643
yarn add @medusajs/file@0.0.2-snapshot-20240916110643
yarn add @medusajs/fulfillment@0.1.3-snapshot-20240916110643
yarn add @medusajs/inventory-next@0.0.4-snapshot-20240916110643
yarn add @medusajs/link-modules@0.2.12-snapshot-20240916110643
yarn add @medusajs/notification@0.1.3-snapshot-20240916110643
yarn add @medusajs/order@0.1.3-snapshot-20240916110643
yarn add @medusajs/payment@0.0.4-snapshot-20240916110643
yarn add @medusajs/pricing@0.1.13-snapshot-20240916110643
yarn add @medusajs/product@0.3.13-snapshot-20240916110643
yarn add @medusajs/promotion@0.0.5-snapshot-20240916110643
yarn add @medusajs/auth-emailpass@0.0.2-snapshot-20240916110643
yarn add @medusajs/auth-github@0.0.2-snapshot-20240916110643
yarn add @medusajs/auth-google@0.0.2-snapshot-20240916110643
yarn add @medusajs/file-local-next@0.0.3-snapshot-20240916110643
yarn add @medusajs/file-s3@0.0.3-snapshot-20240916110643
yarn add @medusajs/fulfillment-manual@0.0.3-snapshot-20240916110643
yarn add @medusajs/notification-local@0.0.2-snapshot-20240916110643
yarn add @medusajs/notification-sendgrid@0.0.2-snapshot-20240916110643
yarn add @medusajs/payment-stripe@0.0.3-snapshot-20240916110643
yarn add @medusajs/region@0.1.2-snapshot-20240916110643
yarn add @medusajs/sales-channel@0.1.2-snapshot-20240916110643
yarn add @medusajs/stock-location-next@0.0.4-snapshot-20240916110643
yarn add @medusajs/store@0.1.2-snapshot-20240916110643
yarn add @medusajs/tax@0.1.2-snapshot-20240916110643
yarn add @medusajs/user@0.0.4-snapshot-20240916110643
yarn add @medusajs/workflow-engine-inmemory@0.0.5-snapshot-20240916110643
yarn add @medusajs/workflow-engine-redis@0.0.5-snapshot-20240916110643

Latest commit: 3e97a64

@sradevski
Copy link
Member

/snapshot-this

1 similar comment
@sradevski
Copy link
Member

/snapshot-this

@carlos-r-l-rodrigues
Copy link
Contributor

Something is affecting the tests in this PR where it can't find the table.
As if it is using a different database other than the one created by moduleIntegrationTestRunner
It can be reproduced locally, on the integration tests of workflow-engine-inmemory.

@thetutlage thetutlage merged commit 653a4bf into develop Sep 17, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants