Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update auth app_metadata when deleting users + customers #9041

Merged
merged 15 commits into from
Sep 10, 2024
Merged

fix: Update auth app_metadata when deleting users + customers #9041

merged 15 commits into from
Sep 10, 2024

Conversation

olivermrbl
Copy link
Contributor

@olivermrbl olivermrbl commented Sep 6, 2024 •
edited
Loading

Closes CC-431

@olivermrbl olivermrbl requested a review from a team as a code owner September 6, 2024 14:31
@vercel Vercel
Copy link

vercel bot commented Sep 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 10, 2024 0:46am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Sep 10, 2024 0:46am
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Sep 10, 2024 0:46am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Sep 10, 2024 0:46am
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Sep 10, 2024 0:46am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Sep 10, 2024 0:46am
resources-docs ⬜️ Ignored (Inspect) Visit Preview Sep 10, 2024 0:46am

@olivermrbl olivermrbl marked this pull request as draft September 6, 2024 14:31
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 6, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 8abae13

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@olivermrbl olivermrbl marked this pull request as ready for review September 6, 2024 15:21
adrien2p
adrien2p approved these changes Sep 9, 2024
View reviewed changes
Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not much except stev comments

packages/core/core-flows/src/customer/workflows/remove-customer-account.ts Outdated Show resolved Hide resolved
@olivermrbl olivermrbl merged commit 4bf42f7 into develop Sep 10, 2024
23 checks passed
@olivermrbl olivermrbl deleted the fix/unset-auth-actor-metadata branch September 10, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sradevski sradevski sradevski approved these changes

@adrien2p adrien2p adrien2p approved these changes

@christiananese christiananese Awaiting requested review from christiananese christiananese is a code owner automatically assigned from medusajs/engineering

@fPolic fPolic Awaiting requested review from fPolic fPolic is a code owner automatically assigned from medusajs/engineering

@carlos-r-l-rodrigues carlos-r-l-rodrigues Awaiting requested review from carlos-r-l-rodrigues carlos-r-l-rodrigues is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
team: medusa type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@olivermrbl @sradevski @adrien2p