fix: wrap ModuleImplementations so that all methods are async #9012
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on slack: modules are wrapped in a proxy which makes all of its methods async. Currently if you try to do declaration merging on th
ModuleImplementations
type, then you can end up getting the wrong types, since non-async methods will not be converted to async on a type level.This PR fixes that by wrapping
ModuleImplementations
in a type that makes all non-async methods async.CLOSES: FRMW-2687