Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashboard): update create fulfillment UI part 1 #8972

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

fPolic
Copy link
Contributor

@fPolic fPolic commented Sep 3, 2024

What

  • update Create fulfillment modal according to the design

Note

  • in a followup I will add support for inventory kits

Question

  • should we support overriding shipping method as per design?

Before:
Screenshot 2024-09-03 at 17 57 18

After:

Screenshot 2024-09-03 at 17 51 26

@fPolic fPolic requested a review from a team as a code owner September 3, 2024 15:55
Copy link

vercel bot commented Sep 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 3, 2024 3:55pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Sep 3, 2024 3:55pm
api-reference-v2 ⬜️ Ignored (Inspect) Sep 3, 2024 3:55pm
docs-ui ⬜️ Ignored (Inspect) Sep 3, 2024 3:55pm
docs-v2 ⬜️ Ignored (Inspect) Sep 3, 2024 3:55pm
medusa-docs ⬜️ Ignored (Inspect) Sep 3, 2024 3:55pm
resources-docs ⬜️ Ignored (Inspect) Sep 3, 2024 3:55pm

Copy link

changeset-bot bot commented Sep 3, 2024

⚠️ No Changeset found

Latest commit: a1601e5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@olivermrbl
Copy link
Contributor

should we support overriding shipping method as per design?

Don't think this is important near term 👍

Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works nicely

@kodiakhq kodiakhq bot merged commit 2a6be52 into develop Sep 4, 2024
23 checks passed
@kodiakhq kodiakhq bot deleted the feat/fulfilment-refresh branch September 4, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants