Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core-flows): custom price flag for order line items and shipping methods #8969

Merged
merged 14 commits into from
Sep 4, 2024
Merged

feat(core-flows): custom price flag for order line items and shipping methods #8969

merged 14 commits into from
Sep 4, 2024

Conversation

carlos-r-l-rodrigues
Copy link
Contributor

@carlos-r-l-rodrigues carlos-r-l-rodrigues commented Sep 3, 2024 •
edited
Loading

CLOSES: CC-402

@carlos-r-l-rodrigues carlos-r-l-rodrigues requested a review from a team as a code owner September 3, 2024 14:22
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 3, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: a601264

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Sep 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ❌ Failed (Inspect) Sep 4, 2024 8:19pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Sep 4, 2024 8:19pm
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Sep 4, 2024 8:19pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Sep 4, 2024 8:19pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Sep 4, 2024 8:19pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Sep 4, 2024 8:19pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Sep 4, 2024 8:19pm

fPolic
fPolic approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@fPolic fPolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

integration-tests/http/__tests__/claims/claims.spec.ts Outdated Show resolved Hide resolved
@kodiakhq kodiakhq bot removed the automerge label Sep 4, 2024
@kodiakhq kodiakhq
Copy link
Contributor

kodiakhq bot commented Sep 4, 2024

This PR currently has a merge conflict. Please resolve this and then re-add the automerge label.

@kodiakhq kodiakhq bot merged commit 2a055b7 into develop Sep 4, 2024
22 of 23 checks passed
@kodiakhq kodiakhq bot deleted the feat/order-flag-custom-price branch September 4, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fPolic fPolic fPolic approved these changes

@sradevski sradevski Awaiting requested review from sradevski sradevski is a code owner automatically assigned from medusajs/engineering

@kasperkristensen kasperkristensen Awaiting requested review from kasperkristensen kasperkristensen is a code owner automatically assigned from medusajs/engineering

@olivermrbl olivermrbl Awaiting requested review from olivermrbl

Assignees
No one assigned
Labels
automerge team: medusa type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carlos-r-l-rodrigues @fPolic