Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(order): order change references #8845

Merged
merged 1 commit into from
Aug 28, 2024
Merged

fix(order): order change references #8845

merged 1 commit into from
Aug 28, 2024

Conversation

carlos-r-l-rodrigues
Copy link
Contributor

No description provided.

@carlos-r-l-rodrigues carlos-r-l-rodrigues requested a review from a team as a code owner August 28, 2024 11:30
@vercel Vercel
Copy link

vercel bot commented Aug 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2024 11:31am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Aug 28, 2024 11:31am
api-reference-v2 ⬜️ Ignored (Inspect) Aug 28, 2024 11:31am
docs-ui ⬜️ Ignored (Inspect) Aug 28, 2024 11:31am
docs-v2 ⬜️ Ignored (Inspect) Aug 28, 2024 11:31am
medusa-docs ⬜️ Ignored (Inspect) Aug 28, 2024 11:31am
resources-docs ⬜️ Ignored (Inspect) Aug 28, 2024 11:31am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 28, 2024

⚠️ No Changeset found

Latest commit: 1174f65

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

carlos-r-l-rodrigues
carlos-r-l-rodrigues commented Aug 28, 2024
View reviewed changes
integration-tests/http/__tests__/claims/claims.spec.ts
@@ -427,11 +427,11 @@ medusaIntegrationTestRunner({

expect(orderResult.summary).toEqual(
expect.objectContaining({
paid_total: 0,
paid_total: 61,
Copy link
Contributor Author

@carlos-r-l-rodrigues carlos-r-l-rodrigues Aug 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason for these adjustments is that this test was merged with a .only.

fPolic
fPolic approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@fPolic fPolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlos-r-l-rodrigues carlos-r-l-rodrigues merged commit 8dea3e4 into develop Aug 28, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fPolic fPolic fPolic approved these changes

@riqwan riqwan Awaiting requested review from riqwan riqwan is a code owner automatically assigned from medusajs/engineering

@adrien2p adrien2p Awaiting requested review from adrien2p adrien2p is a code owner automatically assigned from medusajs/engineering

@olivermrbl olivermrbl Awaiting requested review from olivermrbl olivermrbl is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
team: medusa type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carlos-r-l-rodrigues @fPolic