Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dashboard,js-sdk): fixes from rma flows testing #8826

Merged
merged 3 commits into from
Aug 28, 2024
Merged

fix(dashboard,js-sdk): fixes from rma flows testing #8826

merged 3 commits into from
Aug 28, 2024

Conversation

riqwan
Copy link
Contributor

@riqwan riqwan commented Aug 27, 2024 •
edited
Loading

what:

  1. explicit receive items
explicit-receive-items
  1. Quick view for activity timeline - returns, claims and exchanges
quick-view
  1. Explicit buttons for claims, exchanges & returns
explicit-buttons
  1. Prompts before confirming in all rma flows
prompt

@vercel Vercel
Copy link

vercel bot commented Aug 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2024 8:36am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Aug 28, 2024 8:36am
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Aug 28, 2024 8:36am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Aug 28, 2024 8:36am
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Aug 28, 2024 8:36am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Aug 28, 2024 8:36am
resources-docs ⬜️ Ignored (Inspect) Visit Preview Aug 28, 2024 8:36am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 27, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 4422107

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@riqwan riqwan marked this pull request as ready for review August 27, 2024 21:34
@riqwan riqwan requested a review from a team as a code owner August 27, 2024 21:34
olivermrbl
olivermrbl approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, created this ticket for a minor styling issue.

@riqwan riqwan merged commit c72b484 into develop Aug 28, 2024
23 checks passed
@riqwan riqwan deleted the fix/rma-tests branch August 28, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl approved these changes

@sradevski sradevski Awaiting requested review from sradevski sradevski is a code owner automatically assigned from medusajs/engineering

@adrien2p adrien2p Awaiting requested review from adrien2p adrien2p is a code owner automatically assigned from medusajs/engineering

@kasperkristensen kasperkristensen Awaiting requested review from kasperkristensen kasperkristensen is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
team: medusa type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@riqwan @olivermrbl