Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup error output and do not add red color to help output #8778

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

thetutlage
Copy link
Contributor

Currently the error output of our CLI is all over the place. This PR is a small attempt to clean it up.

  • Now we will show the error as the first thing.
  • Followed by the suggestions.
  • Followed by any other fatal exception (if exists).

Also the red color help output has been normalized to have no colors. Otherwise the help output feels like the part of the error.

@thetutlage thetutlage requested a review from a team as a code owner August 27, 2024 07:24
Copy link

vercel bot commented Aug 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview 💬 Add feedback Aug 27, 2024 7:38am
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 27, 2024 7:38am
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Aug 27, 2024 7:38am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Aug 27, 2024 7:38am
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Aug 27, 2024 7:38am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Aug 27, 2024 7:38am
resources-docs ⬜️ Ignored (Inspect) Visit Preview Aug 27, 2024 7:38am

Copy link

changeset-bot bot commented Aug 27, 2024

⚠️ No Changeset found

Latest commit: 84cac39

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@thetutlage thetutlage merged commit 965c3c9 into develop Aug 27, 2024
23 checks passed
@thetutlage thetutlage deleted the refactor/polish-cli-help branch August 27, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants