Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dashboard,core-flows,js-sdk,types): ability to mark payment as paid #8679

Merged
merged 8 commits into from
Aug 20, 2024
Merged

feat(dashboard,core-flows,js-sdk,types): ability to mark payment as paid #8679

merged 8 commits into from
Aug 20, 2024

Conversation

riqwan
Copy link
Contributor

@riqwan riqwan commented Aug 20, 2024

what:

  • adds ability to mark payment collection as paid
markaspaid.mp4

@vercel Vercel
Copy link

vercel bot commented Aug 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 20, 2024 4:45pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Aug 20, 2024 4:45pm
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Aug 20, 2024 4:45pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Aug 20, 2024 4:45pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Aug 20, 2024 4:45pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Aug 20, 2024 4:45pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Aug 20, 2024 4:45pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 20, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 97ad6f9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@riqwan riqwan marked this pull request as ready for review August 20, 2024 16:33
@riqwan riqwan requested a review from a team as a code owner August 20, 2024 16:33
@riqwan riqwan requested review from sradevski, christiananese, olivermrbl and carlos-r-l-rodrigues and removed request for a team August 20, 2024 16:33
@riqwan riqwan changed the base branch from feat/create-or-update-payment-collection to develop August 20, 2024 16:41
@olivermrbl
Copy link
Contributor

You can only mark system payments as paid, correct?

@riqwan
Copy link
Contributor Author

riqwan commented Aug 20, 2024

@olivermrbl yes, thats correct. Did I miss something?

olivermrbl
olivermrbl reviewed Aug 20, 2024
View reviewed changes
...rd/src/routes/orders/order-detail/components/order-summary-section/order-summary-section.tsx
@@ -104,10 +110,54 @@ export const OrderSummarySection = ({ order }: OrderSummarySectionProps) => {
(pc) => pc.status === "not_paid"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Can we rely on this check? couldn't there be multiple unpaid collections?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no way to get in this situation through the UI as of yet. So not possible right now. But when we link the payment collection to the order change, we can get rid of this check

@olivermrbl
Copy link
Contributor

olivermrbl commented Aug 20, 2024 •
edited
Loading

@olivermrbl yes, thats correct. Did I miss something?

No no, I am just trying to wrap my head around how this will work with other payment collections on the order 😄

@riqwan riqwan merged commit 8bd2847 into develop Aug 20, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl left review comments

@carlos-r-l-rodrigues carlos-r-l-rodrigues carlos-r-l-rodrigues approved these changes

@sradevski sradevski Awaiting requested review from sradevski sradevski is a code owner automatically assigned from medusajs/engineering

@christiananese christiananese Awaiting requested review from christiananese christiananese is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
team: medusa type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@riqwan @olivermrbl @carlos-r-l-rodrigues