Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dashboard): Fix minor issues with Reservations and Inventroy Create forms #8657

Merged
merged 9 commits into from
Aug 20, 2024
Merged

fix(dashboard): Fix minor issues with Reservations and Inventroy Create forms #8657

merged 9 commits into from
Aug 20, 2024

Conversation

kasperkristensen
Copy link
Contributor

What

  • Makes Inventory form scrollable
  • Adjusts spacing in Inventory form
  • Removes double border from Reservation grid.

Resolves CC-111

@kasperkristensen kasperkristensen requested a review from a team as a code owner August 19, 2024 11:28
@vercel Vercel
Copy link

vercel bot commented Aug 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview 💬 Add feedback Aug 20, 2024 11:18am
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 20, 2024 11:18am
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Aug 20, 2024 11:18am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Aug 20, 2024 11:18am
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Aug 20, 2024 11:18am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Aug 20, 2024 11:18am
resources-docs ⬜️ Ignored (Inspect) Visit Preview Aug 20, 2024 11:18am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 19, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: b8434a2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kasperkristensen kasperkristensen changed the title fix(dashboard): Fix minor issues with Reservations and Inventroy Crete forms fix(dashboard): Fix minor issues with Reservations and Inventroy Create forms Aug 19, 2024
olivermrbl
olivermrbl approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice!

...hboard/src/routes/inventory/inventory-create/components/create-inventory-item-form/schema.ts Outdated
import { z } from "zod"
import { optionalInt } from "../../../../../lib/validation"

export const CreateInventoryItemSchema = z.object({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Isn't this a duplicate of this schema? Or the other way around.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like the files got copied over, as I renamed them in this PR and changed them in another. Deleted the duplicate files now 👍

@kasperkristensen kasperkristensen merged commit cfdd056 into develop Aug 20, 2024
23 checks passed
@kasperkristensen kasperkristensen deleted the fix/inventory-and-reservations-minor-fixes branch August 20, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl approved these changes

@sradevski sradevski Awaiting requested review from sradevski sradevski is a code owner automatically assigned from medusajs/engineering

@riqwan riqwan Awaiting requested review from riqwan riqwan is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
team: medusa type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kasperkristensen @olivermrbl