Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove the endpoint to create a user #8629

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

sradevski
Copy link
Member

No description provided.

@sradevski sradevski requested a review from a team as a code owner August 16, 2024 13:10
Copy link

vercel bot commented Aug 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview 💬 Add feedback Aug 16, 2024 1:50pm
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 16, 2024 1:50pm
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Aug 16, 2024 1:50pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Aug 16, 2024 1:50pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Aug 16, 2024 1:50pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Aug 16, 2024 1:50pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Aug 16, 2024 1:50pm

Copy link

changeset-bot bot commented Aug 16, 2024

⚠️ No Changeset found

Latest commit: 930f8df

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sradevski sradevski force-pushed the fix/remove-post-user-endpoint branch from b549cb7 to 930f8df Compare August 16, 2024 13:49
@sradevski sradevski merged commit 0f24013 into develop Aug 16, 2024
21 of 23 checks passed
@sradevski sradevski deleted the fix/remove-post-user-endpoint branch August 16, 2024 14:12
@haf
Copy link

haf commented Aug 17, 2024

Why did you approve and merge a change that breaks the tests for the same endpoint that you removed?

@carlos-r-l-rodrigues
Copy link
Contributor

@haf the tests removed should break in this PR, we will investigate why they didn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants