Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(medusa,core-flows,types): API to create payment collections for order #8617

Merged
merged 3 commits into from
Aug 16, 2024
Merged

feat(medusa,core-flows,types): API to create payment collections for order #8617

merged 3 commits into from
Aug 16, 2024

Conversation

riqwan
Copy link
Contributor

@riqwan riqwan commented Aug 15, 2024

what:

  • adds an API to create a payment collection for order

@vercel Vercel
Copy link

vercel bot commented Aug 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 16, 2024 8:04am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Aug 16, 2024 8:04am
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Aug 16, 2024 8:04am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Aug 16, 2024 8:04am
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Aug 16, 2024 8:04am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Aug 16, 2024 8:04am
resources-docs ⬜️ Ignored (Inspect) Visit Preview Aug 16, 2024 8:04am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 15, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 97bba7c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@riqwan riqwan marked this pull request as ready for review August 15, 2024 17:28
@riqwan riqwan requested a review from a team as a code owner August 15, 2024 17:28
@riqwan riqwan force-pushed the feat/order-payment-collection branch from f6ab46c to c3bca85 Compare August 15, 2024 17:34
carlos-r-l-rodrigues
carlos-r-l-rodrigues approved these changes Aug 15, 2024
View reviewed changes
packages/core/core-flows/src/order/workflows/create-order-payment-collection.ts
)
}

if (input.amount && MathBN.gt(input.amount, pendingPayment)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we don't need this limitation.
one could pre-charge the order 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are just guard rails until we remove them 😄

packages/core/core-flows/src/order/workflows/create-order-payment-collection.ts Outdated
{ order, input },
({ order, input }) => {
const pendingPayment = MathBN.sub(
order.summary.current_order_total,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here the value is serialized. you can read them from raw_ to keep the precision

olivermrbl
olivermrbl approved these changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kodiakhq kodiakhq bot merged commit adcd256 into develop Aug 16, 2024
23 checks passed
@kodiakhq kodiakhq bot deleted the feat/order-payment-collection branch August 16, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-r-l-rodrigues carlos-r-l-rodrigues carlos-r-l-rodrigues approved these changes

@olivermrbl olivermrbl olivermrbl approved these changes

@christiananese christiananese Awaiting requested review from christiananese christiananese is a code owner automatically assigned from medusajs/engineering

@adrien2p adrien2p Awaiting requested review from adrien2p adrien2p is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
automerge team: medusa type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@riqwan @carlos-r-l-rodrigues @olivermrbl