Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(create-medusa-app): prompt for database name with credentials #8552

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

shahednasser
Copy link
Member

If the default credentials can't connect to the database, prompt for database name along with user and password credentials.

Close #8494

Copy link

vercel bot commented Aug 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 12, 2024 7:44am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Aug 12, 2024 7:44am
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Aug 12, 2024 7:44am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Aug 12, 2024 7:44am
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Aug 12, 2024 7:44am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Aug 12, 2024 7:44am
resources-docs ⬜️ Ignored (Inspect) Visit Preview Aug 12, 2024 7:44am

Copy link

changeset-bot bot commented Aug 12, 2024

⚠️ No Changeset found

Latest commit: 3a51719

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@riqwan riqwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏅

@shahednasser shahednasser merged commit f14f398 into develop Aug 12, 2024
23 checks passed
@shahednasser shahednasser deleted the feat/cma-db-name branch August 12, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create-medusa-app should not make assumptions about database name
2 participants