Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(medusa,core-flows): cart payment collection link #8457

Merged
merged 6 commits into from
Aug 6, 2024
Merged

chore(medusa,core-flows): cart payment collection link #8457

merged 6 commits into from
Aug 6, 2024

Conversation

carlos-r-l-rodrigues
Copy link
Contributor

No description provided.

@carlos-r-l-rodrigues carlos-r-l-rodrigues requested a review from a team as a code owner August 5, 2024 17:01
@vercel Vercel
Copy link

vercel bot commented Aug 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 5, 2024 6:36pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Aug 5, 2024 6:36pm
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Aug 5, 2024 6:36pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Aug 5, 2024 6:36pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Aug 5, 2024 6:36pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Aug 5, 2024 6:36pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Aug 5, 2024 6:36pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 5, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 3c9b587

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

carlos-r-l-rodrigues
carlos-r-l-rodrigues commented Aug 5, 2024
View reviewed changes
integration-tests/modules/__tests__/cart/store/cart.workflows.spec.ts
@@ -1280,15 +1269,15 @@ medusaIntegrationTestRunner({

const paymentCollection =
await paymentModule.createPaymentCollections({
amount: 5000,
amount: 5001,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed here to test when the value has changed.
if the amount and currency_code are the same, the payment collection isn't updated and the session isn't deleted.

carlos-r-l-rodrigues
carlos-r-l-rodrigues commented Aug 5, 2024
View reviewed changes
packages/core/core-flows/src/definition/cart/workflows/add-to-cart.ts
)

refreshPaymentCollectionForCartWorkflow.runAsStep({
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved outside the parallel step as operations there can affect Cart totals.

riqwan
riqwan approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@riqwan riqwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments, overall lgtm! Would recco a second pair of eyes as well.

packages/core/core-flows/src/definition/cart/workflows/refresh-payment-collection.ts Show resolved Hide resolved
packages/core/core-flows/src/definition/cart/workflows/update-line-item-in-cart.ts Outdated Show resolved Hide resolved
packages/core/types/src/cart/workflows.ts Show resolved Hide resolved
@carlos-r-l-rodrigues
Copy link
Contributor Author

/snapshot-this

olivermrbl
olivermrbl approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@carlos-r-l-rodrigues carlos-r-l-rodrigues merged commit 5125d13 into develop Aug 6, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riqwan riqwan riqwan approved these changes

@olivermrbl olivermrbl olivermrbl approved these changes

@sradevski sradevski Awaiting requested review from sradevski sradevski is a code owner automatically assigned from medusajs/engineering

@fPolic fPolic Awaiting requested review from fPolic fPolic is a code owner automatically assigned from medusajs/engineering

@adrien2p adrien2p Awaiting requested review from adrien2p adrien2p is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
team: medusa type: chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carlos-r-l-rodrigues @riqwan @olivermrbl