Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core-flows,payment,medusa,types): Refund reasons management API #8436

Merged
merged 11 commits into from
Aug 6, 2024
Merged

feat(core-flows,payment,medusa,types): Refund reasons management API #8436

merged 11 commits into from
Aug 6, 2024

Conversation

riqwan
Copy link
Contributor

@riqwan riqwan commented Aug 4, 2024 •
edited
Loading

what:

  • Module: Refund Reasons
  • API & Workflows: Refund Reasons
  • Creates db snapshot and aligns models in payment

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 4, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 7ec63ce

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Aug 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 6, 2024 9:32am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Aug 6, 2024 9:32am
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Aug 6, 2024 9:32am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Aug 6, 2024 9:32am
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Aug 6, 2024 9:32am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Aug 6, 2024 9:32am
resources-docs ⬜️ Ignored (Inspect) Visit Preview Aug 6, 2024 9:32am

@riqwan riqwan marked this pull request as ready for review August 6, 2024 07:43
@riqwan riqwan requested a review from a team as a code owner August 6, 2024 07:43
@riqwan riqwan changed the title feat(core-flows,payment,medusa,types): add ability to set and manage refund reasons feat(core-flows,payment,medusa,types): Refund reasons management API Aug 6, 2024
olivermrbl
olivermrbl approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, a few nits and questions

packages/core/core-flows/src/payment-collection/steps/create-refund-reasons.ts Outdated Show resolved Hide resolved
packages/core/core-flows/src/payment-collection/workflows/delete-refund-reasons.ts Outdated Show resolved Hide resolved
packages/medusa/src/api/admin/payments/middlewares.ts Outdated Show resolved Hide resolved
@riqwan @olivermrbl
Update packages/core/core-flows/src/payment-collection/steps/create-r…
8f6c0d7 
…efund-reasons.ts

Co-authored-by: Oli Juhl <59018053+olivermrbl@users.noreply.github.com>
@kodiakhq kodiakhq bot removed the automerge label Aug 6, 2024
@kodiakhq kodiakhq
Copy link
Contributor

kodiakhq bot commented Aug 6, 2024

This PR currently has a merge conflict. Please resolve this and then re-add the automerge label.

@riqwan riqwan merged commit 0ff5b97 into develop Aug 6, 2024
23 checks passed
@riqwan riqwan deleted the feat/refund-reasons branch August 6, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl approved these changes

@sradevski sradevski Awaiting requested review from sradevski sradevski is a code owner automatically assigned from medusajs/engineering

@adrien2p adrien2p Awaiting requested review from adrien2p adrien2p is a code owner automatically assigned from medusajs/engineering

@carlos-r-l-rodrigues carlos-r-l-rodrigues Awaiting requested review from carlos-r-l-rodrigues carlos-r-l-rodrigues is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
team: medusa type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@riqwan @olivermrbl @thetutlage