Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix ModuleRegistrationName import #8434

Merged

Conversation

letalumil
Copy link
Contributor

Closes #8433

@letalumil letalumil requested a review from a team as a code owner August 4, 2024 11:01
Copy link

changeset-bot bot commented Aug 4, 2024

⚠️ No Changeset found

Latest commit: 6073d34

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Aug 4, 2024

@letalumil is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@shahednasser shahednasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@kodiakhq kodiakhq bot merged commit be8afca into medusajs:develop Aug 5, 2024
23 of 30 checks passed
@letalumil letalumil deleted the docs/fix-ModuleRegistrationName-import branch August 12, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs(Code Issue): ModuleRegistrationName is incorrectly imported from @medusajs/modules-sdk
2 participants