Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Check for existence of modules when seeding default data #8406

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

sradevski
Copy link
Member

No description provided.

@sradevski sradevski requested a review from a team as a code owner August 2, 2024 08:32
Copy link

vercel bot commented Aug 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 2, 2024 8:33am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Aug 2, 2024 8:33am
api-reference-v2 ⬜️ Ignored (Inspect) Aug 2, 2024 8:33am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Aug 2, 2024 8:33am
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Aug 2, 2024 8:33am
medusa-docs ⬜️ Ignored (Inspect) Aug 2, 2024 8:33am
resources-docs ⬜️ Ignored (Inspect) Aug 2, 2024 8:33am

Copy link

changeset-bot bot commented Aug 2, 2024

⚠️ No Changeset found

Latest commit: 5124a13

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, eventually I would add allowUnregistered on the resolve just for extra precaution :)

Copy link
Contributor

@riqwan riqwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, whats the use-case for this one?

note: might be worth adding a console.warn

@sradevski
Copy link
Member Author

@riqwan the default workflow runs on startup, but in platform I am not using the sales channels and stores modules, so it crashes.

@kodiakhq kodiakhq bot merged commit dbfc145 into develop Aug 2, 2024
23 checks passed
@kodiakhq kodiakhq bot deleted the fix/check-module-existence-default-workflow branch August 2, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants