Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core-flows,order,medusa): exchange endpoints #8396

Merged
merged 7 commits into from
Aug 6, 2024
Merged

feat(core-flows,order,medusa): exchange endpoints #8396

merged 7 commits into from
Aug 6, 2024

Conversation

carlos-r-l-rodrigues
Copy link
Contributor

Order Exchange: PR 2:n

What:

  • Order Exchange endpoints
  • Claims and Exchange worfklows fixes
  • Small fixes on Order module action validations

Next PR will contain inventory management of claims and exchanges.

@carlos-r-l-rodrigues carlos-r-l-rodrigues requested a review from a team as a code owner August 1, 2024 17:37
@vercel Vercel
Copy link

vercel bot commented Aug 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 5, 2024 0:28am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Aug 5, 2024 0:28am
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Aug 5, 2024 0:28am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Aug 5, 2024 0:28am
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Aug 5, 2024 0:28am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Aug 5, 2024 0:28am
resources-docs ⬜️ Ignored (Inspect) Visit Preview Aug 5, 2024 0:28am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 1, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: a7579d4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@carlos-r-l-rodrigues carlos-r-l-rodrigues changed the title chore(core-flows,order,medusa): exchange endpoints feat(core-flows,order,medusa): exchange endpoints Aug 2, 2024
olivermrbl
olivermrbl approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of stuff in this PR. Can we try to keep them smaller going forward because it's a bit hard to review?

I left a few comment, but I would be OK getting this merged so it doesn't block any UI implementation work.

packages/core/core-flows/src/order/workflows/exchange/remove-exchange-item-action.ts
)

export const removeItemExchangeActionWorkflowId = "remove-item-exchange-action"
export const removeItemExchangeActionWorkflow = createWorkflow(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would love to get these steps to be reusable soon 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will work to clean these similar steps everywhere in Order flows

packages/medusa/src/api/admin/exchanges/[id]/inbound/items/[action_id]/route.ts
@@ -0,0 +1,96 @@
import {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Why do we fetch and return returns in these endpoints when they are for exchanges?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In practice, inbounds are returns

packages/medusa/src/api/admin/exchanges/[id]/inbound/items/route.ts
@@ -0,0 +1,60 @@
import { orderExchangeRequestItemReturnWorkflow } from "@medusajs/core-flows"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same question here

packages/medusa/src/api/admin/exchanges/[id]/inbound/shipping-method/[action_id]/route.ts
@@ -0,0 +1,110 @@
import {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question here, will not comment more on this anymore if there are other similar endpoints.

@carlos-r-l-rodrigues carlos-r-l-rodrigues merged commit f415e66 into develop Aug 6, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl approved these changes

@sradevski sradevski Awaiting requested review from sradevski sradevski is a code owner automatically assigned from medusajs/engineering

@fPolic fPolic Awaiting requested review from fPolic fPolic is a code owner automatically assigned from medusajs/engineering

@adrien2p adrien2p Awaiting requested review from adrien2p adrien2p is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
team: medusa type: chore type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carlos-r-l-rodrigues @olivermrbl