Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dashboard,js-sdk,types): add ability to capture payment from order page #8368

Merged
merged 3 commits into from
Aug 1, 2024
Merged

feat(dashboard,js-sdk,types): add ability to capture payment from order page #8368

merged 3 commits into from
Aug 1, 2024

Conversation

riqwan
Copy link
Contributor

@riqwan riqwan commented Jul 31, 2024 •
edited
Loading

what:

  • adds ability to capture payment from order page

bugs found:

  • when capturing payment of one order, other orders statuses get affected from "captured" to "partially captured". Will investigate this separately.
capture-payment.mp4

@vercel Vercel
Copy link

vercel bot commented Jul 31, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2024 5:35pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Jul 31, 2024 5:35pm
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Jul 31, 2024 5:35pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Jul 31, 2024 5:35pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Jul 31, 2024 5:35pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Jul 31, 2024 5:35pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Jul 31, 2024 5:35pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 31, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: da97eeb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@riqwan riqwan marked this pull request as ready for review July 31, 2024 10:12
@riqwan riqwan requested a review from a team as a code owner July 31, 2024 10:12
fPolic
fPolic reviewed Jul 31, 2024
View reviewed changes
packages/core/js-sdk/src/admin/payment.ts Outdated
this.client = client
}

async capture(id: string, headers?: ClientHeaders) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo: we should add body: {amount?: number} to match the API

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, added them!

@riqwan riqwan requested a review from fPolic July 31, 2024 17:33
fPolic
fPolic approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@fPolic fPolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kodiakhq kodiakhq bot merged commit 3169543 into develop Aug 1, 2024
23 checks passed
@kodiakhq kodiakhq bot deleted the feat/capture-payment branch August 1, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fPolic fPolic fPolic approved these changes

@sradevski sradevski Awaiting requested review from sradevski sradevski is a code owner automatically assigned from medusajs/engineering

@adrien2p adrien2p Awaiting requested review from adrien2p adrien2p is a code owner automatically assigned from medusajs/engineering

@carlos-r-l-rodrigues carlos-r-l-rodrigues Awaiting requested review from carlos-r-l-rodrigues carlos-r-l-rodrigues is a code owner automatically assigned from medusajs/engineering

@kasperkristensen kasperkristensen Awaiting requested review from kasperkristensen

@olivermrbl olivermrbl Awaiting requested review from olivermrbl

Assignees
No one assigned
Labels
automerge team: medusa type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@riqwan @fPolic @olivermrbl