Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(orchestration,workflows-sdk): Skip step #8334

Merged
merged 7 commits into from
Jul 29, 2024

Conversation

carlos-r-l-rodrigues
Copy link
Contributor

What:

  • Transaction Orchestrator skipStep
  • new response object for workflows-sdk: StepResponse.skip()

Copy link

changeset-bot bot commented Jul 29, 2024

⚠️ No Changeset found

Latest commit: 32773df

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jul 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2024 4:10pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Jul 29, 2024 4:10pm
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Jul 29, 2024 4:10pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Jul 29, 2024 4:10pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Jul 29, 2024 4:10pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Jul 29, 2024 4:10pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Jul 29, 2024 4:10pm

@carlos-r-l-rodrigues carlos-r-l-rodrigues changed the title feat(orchestartion,workflows-sdk): Skip step feat(orchestration,workflows-sdk): Skip step Jul 29, 2024
@adrien2p
Copy link
Member

As discussed we can add it to the WHEN when it is false to have the info it has been skipped

@adrien2p
Copy link
Member

adrien2p commented Jul 29, 2024

CC @thetutlage we can return StepResponse.skip from our placeholder step once this pr is merged 👍
ref: feat/workflow-hooks

@thetutlage
Copy link
Contributor

What's the purpose of skip? Is it to ignore the return value or to create a dummy step without any invokeFn?

@adrien2p
Copy link
Member

What's the purpose of skip? Is it to ignore the return value or to create a dummy step without any invokeFn?

Mostly to have its real state and being able to display it properly. Instead of marking it as run and success but nothing really ran. Same when you apply the when conditional util

@carlos-r-l-rodrigues carlos-r-l-rodrigues merged commit 24c105f into develop Jul 29, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants