Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for product imports #8298

Merged
merged 2 commits into from
Jul 30, 2024
Merged

feat: Add support for product imports #8298

merged 2 commits into from
Jul 30, 2024

Conversation

sradevski
Copy link
Member

@sradevski sradevski commented Jul 26, 2024 •
edited
Loading

Depends on #8281 (will retarget to develop once that is merged)

Designs: https://www.figma.com/design/z3aUuOVWUKmdHH0ofmMpEV/Web-app-3.0?node-id=6612-67477&t=FQjXXVUyAbMvFhfh-0

CLOSES CC-253

@sradevski sradevski requested a review from a team as a code owner July 26, 2024 14:16
@sradevski sradevski requested review from carlos-r-l-rodrigues, kasperkristensen and olivermrbl and removed request for a team July 26, 2024 14:16
@vercel Vercel
Copy link

vercel bot commented Jul 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 30, 2024 1:13pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Jul 30, 2024 1:13pm
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Jul 30, 2024 1:13pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Jul 30, 2024 1:13pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Jul 30, 2024 1:13pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Jul 30, 2024 1:13pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Jul 30, 2024 1:13pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 26, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 97499c4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

sradevski
sradevski commented Jul 26, 2024
View reviewed changes
packages/admin-next/dashboard/src/components/common/file-preview/file-preview.tsx
)
}

const FileThumbnail = () => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not really an icon, so I wasn't sure how to handle it. I think having it defined here is fine, but let me know if another place would be better.

packages/admin-next/dashboard/src/routes/products/product-import/product-import.tsx Outdated Show resolved Hide resolved
@sradevski sradevski requested a review from fPolic July 26, 2024 14:26
@sradevski sradevski force-pushed the feat/add-support-export-product-ui branch 4 times, most recently from 9b833b2 to 0d4099f Compare July 29, 2024 18:30
@sradevski sradevski force-pushed the feat/add-support-product-import branch from c08b8c6 to c1ada67 Compare July 29, 2024 18:30
Base automatically changed from feat/add-support-export-product-ui to develop July 29, 2024 19:50
@sradevski sradevski force-pushed the feat/add-support-product-import branch from c1ada67 to 97499c4 Compare July 30, 2024 13:12
riqwan
riqwan approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@riqwan riqwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🤞🏻

@sradevski sradevski merged commit 1066499 into develop Jul 30, 2024
23 checks passed
@sradevski sradevski deleted the feat/add-support-product-import branch July 30, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riqwan riqwan riqwan approved these changes

@carlos-r-l-rodrigues carlos-r-l-rodrigues Awaiting requested review from carlos-r-l-rodrigues carlos-r-l-rodrigues is a code owner automatically assigned from medusajs/engineering

@kasperkristensen kasperkristensen Awaiting requested review from kasperkristensen kasperkristensen is a code owner automatically assigned from medusajs/engineering

@olivermrbl olivermrbl Awaiting requested review from olivermrbl olivermrbl is a code owner automatically assigned from medusajs/engineering

@fPolic fPolic Awaiting requested review from fPolic

Assignees
No one assigned
Labels
team: medusa type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sradevski @riqwan @olivermrbl