Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added and updated TSDocs of order module service #8246

Merged
merged 8 commits into from
Aug 6, 2024

Conversation

shahednasser
Copy link
Member

@shahednasser shahednasser commented Jul 23, 2024

  • Added/updated TSDocs of the order module's service type + other related types.
  • Renamed parameter names that were inconsistent / had typos

Note: found some minor inconsistencies in some of the method signatures. Will open a separate PR to resolve them.

Closes DOCS-783

@shahednasser shahednasser requested a review from a team as a code owner July 23, 2024 15:06
Copy link

vercel bot commented Jul 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 6, 2024 7:05am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Aug 6, 2024 7:05am
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Aug 6, 2024 7:05am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Aug 6, 2024 7:05am
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Aug 6, 2024 7:05am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Aug 6, 2024 7:05am
resources-docs ⬜️ Ignored (Inspect) Visit Preview Aug 6, 2024 7:05am

Copy link

changeset-bot bot commented Jul 23, 2024

⚠️ No Changeset found

Latest commit: 26c945d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kodiakhq kodiakhq bot merged commit f04adaf into develop Aug 6, 2024
23 checks passed
@kodiakhq kodiakhq bot deleted the chore/order-tsdocs branch August 6, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants