Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update the jobs readme description #796

Merged
merged 5 commits into from
Jul 2, 2024
Merged

fix: Update the jobs readme description #796

merged 5 commits into from
Jul 2, 2024

Conversation

sradevski
Copy link
Member

No description provided.

shahednasser
shahednasser requested changes Jul 2, 2024
View reviewed changes
Copy link
Member

@shahednasser shahednasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this, wasn't aware that scheduled jobs are ready for use now so need to update the docs as well 👍🏻

Shouldn't the example code be updated as well?

src/jobs/README.md Outdated Show resolved Hide resolved
src/jobs/README.md Outdated Show resolved Hide resolved
sradevski and others added 3 commits July 2, 2024 10:21
@sradevski @shahednasser
Update src/jobs/README.md
b6a5729 
Co-authored-by: Shahed Nasser <shahednasser@gmail.com>
@sradevski @shahednasser
Update src/jobs/README.md
365623e 
Co-authored-by: Shahed Nasser <shahednasser@gmail.com>
@sradevski
Update README.md
15454f5
@sradevski
Copy link
Member Author

@shahednasser yes indeed, thanks for catching that. Updated it now

shahednasser
shahednasser approved these changes Jul 2, 2024
View reviewed changes
Copy link
Member

@shahednasser shahednasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made direct edits to code snippet, hope that's ok 😄

LGTM Thanks!

@sradevski
Copy link
Member Author

Yes ofc, thanks @shahednasser

@shahednasser shahednasser merged commit e04e52a into feat/v2 Jul 2, 2024
3 checks passed
@shahednasser shahednasser deleted the fix/update-jobs-readme branch July 2, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahednasser shahednasser shahednasser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sradevski @shahednasser