feat: update proto and test code due to panacea-core upgrade #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
audtlr24
requested review from
youngjoon-lee,
cl9200,
gyuguen,
0xHansLee and
inchori
|
It would be good to remove all related to |
|
Is this status a |
youngjoon-lee
approved these changes
Oct 25, 2022
proto_update_dep.sh
Outdated
Comment on lines
16
to
17
| PANACEA_CORE_VER_SHORT="ft-na-v2.0.5-cosmos-sdk-v0.45.9-dragonberry" | ||
| PANACEA_CORE_VER="ft/na/v2.0.5-cosmos-sdk-v0.45.9-dragonberry" |
| @@ -156,7 +157,7 @@ private TxResponse pollTxResponse(String txHash, int maxTries, int sleepMs) thro | |||
| } catch (StatusRuntimeException e) { | |||
| // if tx was not found (if tx isn't included in the block yet) | |||
| // Misc: Yeah. I know that the status code INVALID_ARGUMENT isn't proper, but it's the way how Cosmos was implemented. | |||
There was a problem hiding this comment.
you can delete this Misc comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change proto file & test code with panacea-core related this PR (medibloc/panacea-core#468)
INVALID_ARGUMENT->NOT_FOUND)