Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add skeleton code for oracle module #517

Merged
merged 13 commits into from
Dec 6, 2022
Merged

Conversation

audtlr24
Copy link
Contributor

@audtlr24 audtlr24 commented Dec 5, 2022

Add skeleton code for x/oracle.

  • add oracle.Params to GenesisState

@audtlr24 audtlr24 added this to the v2.1.0-beta milestone Dec 5, 2022
@audtlr24 audtlr24 requested a review from cl9200 as a code owner December 5, 2022 06:03
@audtlr24 audtlr24 self-assigned this Dec 5, 2022
@youngjoon-lee youngjoon-lee linked an issue Dec 5, 2022 that may be closed by this pull request
Copy link
Contributor

@youngjoon-lee youngjoon-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

@inchori inchori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I left an one question.

}
}

func GetGenesisStateFromAppState(cdc codec.Codec, appState map[string]json.RawMessage) *GenesisState {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a question. Is this function neccessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the function used in the command to add genesis oracle. It's not important right now, but I think it will be used later.

Copy link
Contributor

@0xHansLee 0xHansLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@gyuguen gyuguen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from ft/508/skeleton_scalable to main December 6, 2022 00:51
…racle

# Conflicts:
#	.github/workflows/ci.yml
#	proto/panacea/datadeal/v2/deal.proto
#	proto/panacea/datadeal/v2/genesis.proto
#	proto/panacea/datadeal/v2/query.proto
#	proto/panacea/datadeal/v2/tx.proto
#	proto/panacea/oracle/v2/genesis.proto
#	proto/panacea/oracle/v2/oracle.proto
#	x/datadeal/types/deal.pb.go
#	x/datadeal/types/genesis.pb.go
#	x/datadeal/types/query.pb.go
#	x/datadeal/types/tx.pb.go
#	x/oracle/types/genesis.pb.go
#	x/oracle/types/oracle.pb.go
@audtlr24 audtlr24 merged commit 720d788 into main Dec 6, 2022
@audtlr24 audtlr24 deleted the ft/na/skeleton_code_oracle branch December 6, 2022 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define x/oracle and x/datadeal with proto files
5 participants