Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [v0.45.9] add minimum commission rate to x/staking (cherry-picked from aca9d7cb5a593f10e964fad8fd47c20486634c7c) #124

Merged
merged 2 commits into from
Oct 18, 2022

Conversation

youngjoon-lee
Copy link

@youngjoon-lee youngjoon-lee commented Oct 16, 2022

Cherry-picked from aca9d7c for the new v0.45.9 release of cosmos/cosmos-sdk. This is supposed to be released as medibloc/cosmos-sdk@v0.45.9-panacea.

NOTE: The test-rosetta Github Actions is failing, but we can ignore it. We cannot run that action in our fork, as I understood.

Copy link

@gyuguen gyuguen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link

@0xHansLee 0xHansLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

@inchori inchori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks!

Copy link

@audtlr24 audtlr24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@youngjoon-lee youngjoon-lee merged commit b3c84b5 into v0.45.9-panacea Oct 18, 2022
@youngjoon-lee youngjoon-lee deleted the ft/na/v0.45.9-panacea-min-comm-rate branch October 18, 2022 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants