encodersgpl flavor #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
moffatman
commented
Sep 15, 2023
moffatman
commented
- Add fftools-ffi
- Replace libressl with mbedtls (licensing)
- Fix and enable assembly optimizations
- Add fftools-ffi - Replace libressl with mbedtls (licensing) - Fix and enable assembly optimizations
Some packages can't (`fftools-ffi`) or aren't (`x264`) indexed on Homebrew, so we'll update them manually.
The `sys_root` property in cross-files prevents `ffmpeg` from finding `mbedtls`.
This reverts commit f5efd08.
birros
approved these changes
Sep 17, 2023
There was a problem hiding this comment.
LGTM!
No regression for default and full.
@moffatman I'll let you check the encodersgpl builds.
|
These encodersgpl builds look good on both macos and ios |
alexmercerind
approved these changes
Sep 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.