Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Additional SMTP Headers to Decrease Spam Score #3031

Conversation

michael-genson
Copy link
Collaborator

What type of PR is this?

(REQUIRED)

  • bug
  • feature

What this PR does / why we need it:

(REQUIRED)

Adds missing headers detailed in #2993 (and #3028) to decrease our spam score

Which issue(s) this PR fixes:

(REQUIRED)

Closes #2993
Fixes #3028

Copy link
Collaborator

@Kuchenpirat Kuchenpirat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@Kuchenpirat Kuchenpirat merged commit 702907f into mealie-recipes:mealie-next Jan 22, 2024
9 checks passed
@be-joeri
Copy link
Contributor

Hi!

Thanks for implementing this, spam score looks much better now.

Two remarks:

  • the message ID is missing brackets (< >), guess you can just add them when you generate the message_id variable on lines 48 and 52.
  • the plain text part is shown in mail clients following RFC 2046 (Gmail for example). The last part of a multipart message is considered best and is preferred, so you should add the text part first and the html part second. You can fix this by swapping lines 44 and 45.

Keep up the good work!

@boc-the-git
Copy link
Collaborator

Hey @be-joeri, good detailed feedback there, thanks. This sounds like a great opportunity to get your first PR merged! :)
The README has a section on contributing as a starting point if needed, and we welcome all the help!
The Discord is also very friendly if you had a specific thing you needed help with while working through the process.

@be-joeri
Copy link
Contributor

be-joeri commented Feb 1, 2024

Hi @boc-the-git,

Thanks for suggesting to create a PR.
I'm not really a coder and the whole process is new to me, so reading instructions and setting things up took a lot more time than the actual change :)
I created #3094 . Please let me know if I made a mistake somewhere so I can take that into account next time.

@boc-the-git
Copy link
Collaborator

Well done @be-joeri!! First PR is a great milestone. Hopefully the first of many (be they for Mealie or other projects).

Given you mention your lack of familiarity with doing stuff like this, if there's anything in the docs that could be made more clear, from your experience, please let us know!

@michael-genson michael-genson deleted the feat/decrease-smtp-spam-score branch February 2, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - No Date header in test email?
4 participants