Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: more shopping list enhancements #2587

Conversation

michael-genson
Copy link
Collaborator

What type of PR is this?

(REQUIRED)

  • bug
  • feature

What this PR does / why we need it:

(REQUIRED)

A bunch of enhancements to the shopping list:

  • fixed some visual bugs
  • fixed random list item re-ordering nonsense and made it consistent

And I added a task that purges old, checked-off shopping list items over a threshold (currently set to 100). I have a feeling a lot of users don't know how big their "checked-off" list gets, which eventually bogs down the shopping list.

Which issue(s) this PR fixes:

(REQUIRED)

N/A

Testing

(fill-in or delete this section)

Pytest for the new task

Release Notes

(REQUIRED)

fixed some visual shopping list bugs
fixed shopping list items re-arranging themselves in certain instances
automatically delete older checked-off shopping list items when there are more than 100 of them

frontend/pages/shopping-lists/_id.vue Outdated Show resolved Hide resolved
@michael-genson
Copy link
Collaborator Author

I think I did the reduce right? Pretty sure it works

@hay-kot hay-kot merged commit b153ddf into mealie-recipes:mealie-next Oct 7, 2023
6 checks passed
@michael-genson michael-genson deleted the feat/shopping-list-enhancements branch October 7, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants