Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Tags Import Seems To Not Work When Creating From URL #2504

Conversation

michael-genson
Copy link
Collaborator

What type of PR is this?

(REQUIRED)

  • bug

What this PR does / why we need it:

(REQUIRED)

When a recipe is imported via URL and the user opts to import tags, it seems to not work in some scenarios. While everything is handled on the backend properly, when new tags are created, the frontend displays them inconsistently (sometimes they're not there, sometimes they're there but if you click on them you get weird behavior).

The root cause of this is that the frontend doesn't refresh the tag store before switching to the recipe, so when the frontend tries to route you to the new tag it fails to find it. If you go straight to edit mode, since the new tags are missing, they are removed from the recipe (since they aren't in the dropdown).

This PR forces the frontend to refresh the tag store if the user opts to import tags from the recipe, before routing the user to the new recipe.

Which issue(s) this PR fixes:

(REQUIRED)

Fixes #2488

Testing

(fill-in or delete this section)

Reproduced the issue locally, unable to reproduce after the fix.

Release Notes

(REQUIRED)

fixed tags not importing properly when creating new recipes via URL

@hay-kot hay-kot merged commit 1e693fd into mealie-recipes:mealie-next Aug 21, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tag import not working when "stay in edit mode"
2 participants