Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for broken frontend development #2357

Merged

Conversation

michael-genson
Copy link
Collaborator

What type of PR is this?

(REQUIRED)

  • bug

What this PR does / why we need it:

(REQUIRED)

Which issue(s) this PR fixes:

(REQUIRED)

Discussed in Discord. Not my fix, thanks @fleshgolem!

Testing

(fill-in or delete this section)

I played around in the frontend and everything seems to be working right. I didn't update nuxt-vite, only the postcss and ufo packages, and it seems to be working fine.

Release Notes

(REQUIRED)

NONE

@fleshgolem
Copy link
Contributor

I think this should really use the form where only the sub-dependency of that specific dependency is pinned, otherwise we might run into serious issues down the line, because e.g. some other packages that depend on ufo > 1.0 (there are some) will stop working correctly

This would be "@nuxtjs/i18n/**/ufo": "0.7.9" for ufo and it should probably be doable as well for postcss-preset-env as well, but i dont know from the top of my head anymore what required what here. I can look it up in the evening if you want though

@michael-genson
Copy link
Collaborator Author

michael-genson commented Apr 24, 2023

I think this should really use the form where only the sub-dependency of that specific dependency is pinned

TIL that's a thing. I'm primarily a Python dev, lol. I'll try pinning it for just nuxtjs, and if that doesn't work figure out what else needs it. Thanks!

@michael-genson
Copy link
Collaborator Author

Pinning to just nuxtjs/i18n seems to still do the trick, without pinning it for postcss. I definitely encourage grabbing it yourself and confirming though

@hay-kot hay-kot merged commit 0e397b3 into mealie-recipes:mealie-next Apr 25, 2023
@michael-genson michael-genson deleted the fix/frontend-development branch April 25, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants